Clean BlockMover component focus style #44241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 19, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Looks good.
Before:
After:
Thie focus style is a little clearer because of this, but it's important to note that the size of the clickable area does not change, and remains as large as it was before. This is only a question of focus style legibility.
Contributor
Author
|
Thank you for the review, @jasmussen ! |
michalczaplinski
added
[Type] Bug
Contributor
|
I think this probably caused this regression #45088 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on: #40379
What?
This PR adjusts the position and size of the BlockMover component focus outline.
Why?
In the vertical control, the focus outline is off-center.
In the horizontal control, only this focus style extends the full vertical width.
How?
Adjusted position and size to match the focus style of the other buttons.
This will unify the focus outline of the block mover to 32 x 20px. This is the same size as the drag button focus outline.
Screenshots or screencast