Skip to content

Add layout styles from Post Content block to post editor #44258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tellthemachines merged 14 commits into from
Sep 27, 2022
Merged

Add layout styles from Post Content block to post editor #44258

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
95cb34a
Add layout styles from Post Content block to post editor
tellthemachines Sep 19, 2022
84cddef
Fix post content finding logic.
tellthemachines Sep 20, 2022
0128131
Remove extra styles when Post Content block exists.
tellthemachines Sep 20, 2022
b8d56b8
templateContent should always be a string
tellthemachines Sep 20, 2022
58a2580
Memoise post content block.
tellthemachines Sep 20, 2022
602c7df
Change function signature and mark experimental
tellthemachines Sep 21, 2022
7102ea3
_Really_ make sure templateContent is a string
tellthemachines Sep 21, 2022
1b29729
Update layout type for legacy layouts.
tellthemachines Sep 21, 2022
08fe809
Fix selector specificity and legacy layout logic.
tellthemachines Sep 21, 2022
eeb03e3
Fix 404s on fetch and only parse content if needed
tellthemachines Sep 23, 2022
f2f7e25
Fix acces to layout when no Post Content block
tellthemachines Sep 26, 2022
67c829d
Add doc comment to findPostContent
tellthemachines Sep 26, 2022
bcdeda8
Increase specificity
tellthemachines Sep 26, 2022
fb51a82
Remove unneeded LayoutStyle
tellthemachines Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix acces to layout when no Post Content block
  • Loading branch information
@tellthemachines
tellthemachines committed Sep 26, 2022
commit f2f7e2538789ebb280dc747d38121897c02360fb
3 changes: 1 addition & 2 deletions packages/edit-post/src/components/visual-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,7 @@ export default function VisualEditor( { styles } ) {
'.block-editor-block-list__layout.is-root-container'
);

const { attributes = {} } = postContentBlock;
const { layout = {} } = attributes;
const layout = postContentBlock?.attributes?.layout || {};

// Update type for blocks using legacy layouts.
const postContentLayout =
Expand Down