Skip to content

ToolsPanel: Add subheadings and reset text to tools panel menu #44260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 12 commits into from
Sep 26, 2022
Merged

ToolsPanel: Add subheadings and reset text to tools panel menu #44260

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
78ac987
Add subheadings and reset text to tools panel menu
aaronrobertshaw Sep 19, 2022
f683d96
Add changelog
aaronrobertshaw Sep 19, 2022
16aec30
Mute disabled default control menu item text
aaronrobertshaw Sep 19, 2022
4c85fcf
Make reset text aria-hidden
aaronrobertshaw Sep 19, 2022
6069466
Further tweaks to default control item text color
aaronrobertshaw Sep 19, 2022
c8fa09d
Refactor reset label text styling
aaronrobertshaw Sep 19, 2022
27cae7c
Remove use of baseLabelTypography mixin
aaronrobertshaw Sep 19, 2022
ecffad0
Only render menu item shortcut and right icon if no suffix
aaronrobertshaw Sep 20, 2022
c78a22a
Remove reset suffix when the menu item is disabled
aaronrobertshaw Sep 21, 2022
9869bb6
Fix allowance for icon width in unchecked menu items
aaronrobertshaw Sep 21, 2022
beba370
Fix up suffix test for omitting icon
aaronrobertshaw Sep 21, 2022
6ab67b8
Add rtl styling for reset label margin
aaronrobertshaw Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove reset suffix when the menu item is disabled
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Sep 21, 2022
commit c78a22ae35fce80d15a797e12c759193ca49a21e
2 changes: 1 addition & 1 deletion packages/components/src/tools-panel/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export const ResetLabel = styled.span`
export const DefaultControlsItem = css`
color: ${ COLORS.gray[ 900 ] };

&[aria-disabled='true'] {
&&[aria-disabled='true'] {
color: ${ COLORS.gray[ 700 ] };
opacity: 1;

Expand Down
1 change: 0 additions & 1 deletion packages/components/src/tools-panel/tools-panel-header/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ const DefaultControlsGroup = ( {
role="menuitemcheckbox"
isSelected
aria-disabled
suffix={ resetSuffix }
>
{ label }
</MenuItem>
Expand Down