Skip to content

Add role=application to list view to prevent browse mode triggering in NVDA #44291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 4 commits into from
Sep 21, 2022
Merged

Add role=application to list view to prevent browse mode triggering in NVDA #44291

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ded249
Add role=application to list view to prevent browse mode triggering i…
talldan Sep 20, 2022
200953e
Move the aria-label to application role.
alexstine Sep 21, 2022
e64ffb9
Add aria-label back to table for now. This broke too many E2E and thi…
alexstine Sep 21, 2022
5932be5
Update snapshots
talldan Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add role=application to list view to prevent browse mode triggering i… 
…n NVDA
  • Loading branch information
@talldan
talldan committed Sep 20, 2022
commit 5ded249eea5c957de8aef0a68d4581e70e65b29e
23 changes: 15 additions & 8 deletions packages/components/src/tree-grid/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,21 @@ function TreeGrid(
/* eslint-disable jsx-a11y/no-noninteractive-element-to-interactive-role */
return (
<RovingTabIndexContainer>
<table
{ ...props }
role="treegrid"
onKeyDown={ onKeyDown }
ref={ ref }
>
<tbody>{ children }</tbody>
</table>
{
// Prevent browser mode from triggering in NVDA by wrapping List View
// in a role=application wrapper.
// see: https://github.com/WordPress/gutenberg/issues/43729
}
<div role="application">
<table
{ ...props }
role="treegrid"
onKeyDown={ onKeyDown }
ref={ ref }
>
<tbody>{ children }</tbody>
</table>
</div>
</RovingTabIndexContainer>
);
/* eslint-enable jsx-a11y/no-noninteractive-element-to-interactive-role */
Expand Down