Popover: convert unit tests to TypeScript and modern RTL assertions#44373
Merged
Popover: convert unit tests to TypeScript and modern RTL assertions#44373
Conversation
ciampo
added
[Type] Code Quality
ciampo
requested review from
chad1008,
mirka,
ntsekouras,
talldan and
walbo
This was referenced Sep 22, 2022
ciampo
commented
Sep 22, 2022
Comment on lines
20
to
24
Contributor
Author
There was a problem hiding this comment.
This was not necessary anymore
ciampo
commented
Sep 22, 2022
Contributor
Author
There was a problem hiding this comment.
This test has been split into two separate tests (should focus the popover by default when opened, should allow focus-on-open behavior to be disabled)
ciampo
force-pushed
the
feat/popover-test-typescript
branch
from
79791c9 to
7c038e5
Compare
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Sep 23, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Nice work 👍
LGTM!
✅ No type or build errors
✅ Unit tests all pass
✅ Tests and code changes make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #35744
Part of #42770
Why?
See #35744
How?
PositionToPlacementTuple,PlacementToAnimationOriginTuple,PlacementToInitialTranslationTuple)document.body)actcalls (no more necessary)Testing Instructions