Skip to content

Components: refactor Sandbox to pass exhaustive-deps #44378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 6 commits into from
Sep 27, 2022
Merged

Components: refactor Sandbox to pass exhaustive-deps #44378

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a48e6c1
Sandbox: protect against `ref.current` changing before cleanup
chad1008 Sep 22, 2022
bf85c94
Sandbox: wrap `trySandbox` in `useCallback`
chad1008 Sep 22, 2022
9e9543d
Components: update CHANGELOG
chad1008 Sep 22, 2022
eab474c
Sandbox: ignore exhaustive-deps warning in native file
chad1008 Sep 22, 2022
eec8709
Sandbox: applly es-lint ignore to useEffect deps warnings. Update ifr…
chad1008 Sep 26, 2022
359be08
Components: update CHANGELOG
chad1008 Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sandbox: ignore exhaustive-deps warning in native file
  • Loading branch information
@chad1008
chad1008 committed Sep 26, 2022
commit eab474c323923b7b3b196e2f2b8219d75d1f0167
3 changes: 3 additions & 0 deletions packages/components/src/sandbox/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ function Sandbox( {

useEffect( () => {
updateContentHtml();
// Disable reason: deferring this refactor to the native team.
// see https://github.com/WordPress/gutenberg/pull/41166
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [ html, title, type, styles, scripts ] );

useEffect( () => {
Expand Down