Skip to content

[TypeScript] Preserve the generic signature of getEntityRecord and getEntityRecords through currying #44453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamziel merged 5 commits into from
Sep 27, 2022
Merged

[TypeScript] Preserve the generic signature of getEntityRecord and getEntityRecords through currying #44453

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1aa5f76
Preserve the generic nature of getEntityRecord and getEntityRecords t…
adamziel Sep 26, 2022
80c0c59
Update docstring wording
adamziel Sep 26, 2022
089a608
Restore autop package README
adamziel Sep 26, 2022
c355086
Make CurriedSignature non-optional
adamziel Sep 26, 2022
30c3495
Restore the inline type annotations to getEntityRecord so they're ref…
adamziel Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docstring wording
  • Loading branch information
@adamziel
adamziel committed Sep 26, 2022
commit 80c0c5931c114ba939020ebb10fa9658555ed2f5
4 changes: 2 additions & 2 deletions packages/core-data/src/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ export function getEntityConfig(
* // (kind: string number, key: false | "string value") => string number
* ```
*
* The signature withot the state parameter shipped as CurriedSignature
* is used in the return value of `dispatch( coreStore )`.
* The signature without the state parameter shipped as CurriedSignature
* is used in the return value of `select( coreStore )`.
*
* See https://github.com/WordPress/gutenberg/pull/41578 for more details.
*/
Expand Down