Skip to content

Theme.json: fix some shadow properties doesn't work properly on the site editor #44569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 1 commit into from
Sep 29, 2022
Merged

Theme.json: fix some shadow properties doesn't work properly on the site editor #44569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/edit-site/src/components/global-styles/use-global-styles-output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ export const getNodesWithStyles = ( tree, blockSelectors ) => {
'typography',
'filter',
'outline',
'shadow',
].includes( key )
);

Expand Down
22 changes: 14 additions & 8 deletions packages/style-engine/src/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ describe( 'getCSSRules', () => {
style: 'dashed',
color: 'red',
},
shadow: '10px 10px red',
},
{
selector: '.some-selector',
Expand Down Expand Up @@ -308,45 +309,50 @@ describe( 'getCSSRules', () => {
value: '5px',
},
{
key: 'fontFamily',
selector: '.some-selector',
key: 'fontFamily',
Copy link
Contributor Author

@t-hamano t-hamano Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From here on down, it also includes changes to unify the order of properties.

Copy link
Member

@ramonjd ramonjd Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up 🙇

value: "'Helvetica Neue',sans-serif",
},
{
key: 'fontSize',
selector: '.some-selector',
key: 'fontSize',
value: '2.2rem',
},
{
key: 'fontStyle',
selector: '.some-selector',
key: 'fontStyle',
value: 'italic',
},
{
key: 'fontWeight',
selector: '.some-selector',
key: 'fontWeight',
value: '800',
},
{
key: 'letterSpacing',
selector: '.some-selector',
key: 'letterSpacing',
value: '12px',
},
{
key: 'lineHeight',
selector: '.some-selector',
key: 'lineHeight',
value: '3.3',
},
{
key: 'textDecoration',
selector: '.some-selector',
key: 'textDecoration',
value: 'line-through',
},
{
key: 'textTransform',
selector: '.some-selector',
key: 'textTransform',
value: 'uppercase',
},
{
selector: '.some-selector',
key: 'boxShadow',
value: '10px 10px red',
},
] );
} );

Expand Down