Skip to content

Update design of FontSizePicker when withSlider is set #44598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 10 commits into from
Oct 24, 2022
Merged

Update design of FontSizePicker when withSlider is set #44598

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c68f0ec
Update design of FontSizePicker when withSlider is true
noisysocks Sep 30, 2022
b02b43e
splitNumberAndUnitFromSize -> parseNumberAndUnitFromSize
noisysocks Oct 4, 2022
9e0a116
Add 8px margin to slider
noisysocks Oct 13, 2022
fb3f709
Add min=0 to UnitControl
noisysocks Oct 13, 2022
5fb3a56
Go back to rounding pixel values when there are no units
noisysocks Oct 13, 2022
1c15c19
Restore previous logic for determining hasUnits
noisysocks Oct 13, 2022
afb70ab
Guard against missing first size
noisysocks Oct 13, 2022
fd6a76a
Use existing parseQuantityAndUnitFromRawValue
noisysocks Oct 24, 2022
df15dc5
Use same min, max and step values as in SpacingSizesControl
noisysocks Oct 24, 2022
f2cc79d
Update CHANGELOG.md
noisysocks Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/hooks/font-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export function FontSizeEdit( props ) {
onChange={ onChange }
value={ fontSizeValue }
withReset={ false }
withSlider
size="__unstable-large"
__nextHasNoMarginBottom
/>
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/font-size-picker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ The current font size value.

### withSlider

If `true`, the UI will contain a slider, instead of a numeric text input field. If `false`, no slider will be present.
If `true`, a slider will be displayed alongside the input field when a custom font size is active. Has no effect when `disableCustomFontSizes` is `true`.

- Type: `Boolean`
- Required: no
- Default: `false`

### withReset

If `true`, a reset button will be displayed alongside the input field when a custom font size is active. Has no effect when `disableCustomFontSizes` or `withSlider` is `true`.
If `true`, a reset button will be displayed alongside the input field when a custom font size is active. Has no effect when `disableCustomFontSizes` is `true`.

- Type: `Boolean`
- Required: no
Expand All @@ -113,4 +113,4 @@ Start opting into the new margin-free styles that will become the default in a f

- Type: `Boolean`
- Required: no
- Default: `false`
- Default: `false`
Loading