Skip to content

Query Loop: Fix condition for displaying 'parents' control #44630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 1 commit into from
Oct 3, 2022
Merged

Query Loop: Fix condition for displaying 'parents' control #44630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Query Loop: Fix condition for displaying 'parents' control 
The logical NOT here is a typo. The Query Loop block should display the filter for hierarchical post types; unless the `allowedControls` list omits the control filter.
  • Loading branch information
@Mamaduka
Mamaduka committed Oct 2, 2022
commit 5b4da51acb5de5d2f337a6e8c76189f20745bf60
5 changes: 1 addition & 4 deletions packages/block-library/src/query/edit/inspector-controls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,7 @@ export default function QueryInspectorControls( {
</ToolsPanelItem>
) }
{ isPostTypeHierarchical &&
! isControlAllowed(
allowedControls,
'parents'
) && (
isControlAllowed( allowedControls, 'parents' ) && (
<ToolsPanelItem
hasValue={ () => !! parents?.length }
label={ __( 'Parents' ) }
Expand Down