Layout: backport code quality changes from core to Gutenberg #44661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
aristath
approved these changes
Oct 4, 2022
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Thank you @andrewserong!
andrewserong
deleted the
try/backporting-core-layout-changes-to-gutenberg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When WordPress/wordpress-develop#3254 was merged into core, it involved a couple of tweaks to documenting, readability improvements, and renaming of some tests. This PR ports those changes back to the Gutenberg plugin.
Why?
As the
layout.phpfile in Gutenberg is evergreen, it's good to try to ensure as much consistency as possible between core and the Gutenberg file.How?
Copy + paste changes from core's
layout.phpand ensure that we keep thegutenberg_prefixed versions of changes in the Gutenberg plugin.Testing Instructions
Check that PHP tests pass.
Smoke test that layout still works correctly (e.g. try out a range of Group, Buttons, and Social Icons blocks in a post, ensure rendering is the same as on trunk)