[Documentation]: Update Extending the Query Loop block docs #44703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
ryanwelcher
reviewed
Oct 5, 2022
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
sunyatasattva
requested changes
Oct 5, 2022
Contributor
sunyatasattva
left a comment
sunyatasattva
left a comment
There was a problem hiding this comment.
Great job clarifying and extending certain parts! Thank you for doing that. Submitted a few suggestions, nothing major.
I noticed you really dislike colons! 😂
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
ntsekouras
commented
Oct 5, 2022
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Welcher <[email protected]> Co-authored-by: Lucio Giannotta <[email protected]>
mcsf
approved these changes
Oct 6, 2022
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Nice and clear; just have one thing to amend.
docs/how-to-guides/block-tutorial/extending-the-query-loop-block.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel Fonseca <[email protected]>
sunyatasattva
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of: #44137