Skip to content

Fluid typography: convert font size inline style attributes to fluid values #44764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 5 commits into from
Oct 10, 2022
Merged

Fluid typography: convert font size inline style attributes to fluid values #44764

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8b9cbf
This commit ensures that custom font size values that appear in the s…
ramonjd Oct 7, 2022
e3ebfd8
Adding comments
ramonjd Oct 7, 2022
7767d4c
Bail early if we don't find a custom font size
ramonjd Oct 9, 2022
dbc2adc
Adding tests yo
ramonjd Oct 9, 2022
d1dfb5f
Updating PHP doc to describe incoming type of $raw_value (string|number)
ramonjd Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updating PHP doc to describe incoming type of $raw_value (string|number)
  • Loading branch information
@ramonjd
ramonjd committed Oct 10, 2022
commit d1dfb5f2bedd8288de8539da88f032381a84ba99
4 changes: 2 additions & 2 deletions lib/block-supports/typography.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ function gutenberg_render_typography_support( $block_content, $block ) {
*
* @access private
*
* @param string $raw_value Raw size value from theme.json.
* @param array $options {
* @param string|number $raw_value Raw size value from theme.json.
* @param array $options {
* Optional. An associative array of options. Default is empty array.
*
* @type string $coerce_to Coerce the value to rem or px. Default `'rem'`.
Expand Down