Make spacingScale description more accurate in theme.json schema
#44794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Developer Documentation
ajlende
approved these changes
Oct 10, 2022
Contributor
|
Thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the description of spacingScale introduced by #41527
Why?
In the input support by JSON schema, the descriptions of
spacingSizesandspacingScaleare exactly the same, so it may be difficult to understand the difference between them.spacingScale
spacingSizes
Furthermore,
spacingScaledoesn'ot generate presets by itself, but is a property that defines the logic for generating presets.How?
I have updated the description to what I think is appropriate according to what this property originally meant.
Testing Instructions
Create a JSON file that references the JSON schema for this branch, such as:
{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/schema/theme-json-spacing-scale/schemas/json/theme.json", "version": 2, "settings": { } }In
settings.spacingScale, confirm that the new description is proposed.