Skip to content

Data: Cleanup useDispatch tests #44856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 3 commits into from
Oct 11, 2022
Merged

Data: Cleanup useDispatch tests #44856

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82984a6
Fix test names
Mamaduka Oct 11, 2022
76e0da8
Create a registry for each test separately
Mamaduka Oct 11, 2022
e40b80b
Avoid testing action calls
Mamaduka Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 5 additions & 55 deletions packages/data/src/components/use-dispatch/test/use-dispatch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,9 @@ describe( 'useDispatch', () => {
},
};

let registry;
beforeEach( () => {
registry = createRegistry();
} );

it( 'returns dispatch function from store with no store name provided', async () => {
const user = userEvent.setup();
const registry = createRegistry();
registry.registerStore( 'demo', counterStore );

const TestComponent = () => {
Expand All @@ -56,9 +52,10 @@ describe( 'useDispatch', () => {
expect( registry.select( 'demo' ).get() ).toBe( 1 );
} );

it( 'returns expected action creators from store for given storeName', async () => {
it( 'returns expected action creators from store for given store descriptor', async () => {
const user = userEvent.setup();
const store = createReduxStore( 'demoStore', counterStore );
const registry = createRegistry();
registry.register( store );

const TestComponent = () => {
Expand All @@ -77,8 +74,9 @@ describe( 'useDispatch', () => {
expect( registry.select( store ).get() ).toBe( 1 );
} );

it( 'returns expected action creators from store for given store descriptor', async () => {
it( 'returns expected action creators from store for given storeName', async () => {
const user = userEvent.setup();
const registry = createRegistry();
registry.registerStore( 'demoStore', counterStore );
const TestComponent = () => {
const { inc } = useDispatch( 'demoStore' );
Expand Down Expand Up @@ -131,52 +129,4 @@ describe( 'useDispatch', () => {
expect( firstRegistry.select( 'demo' ).get() ).toBe( 1 );
expect( secondRegistry.select( 'demo' ).get() ).toBe( 1 );
} );

it( 'dispatches returned actions correctly', async () => {
const user = userEvent.setup();
const fooAction = jest.fn( () => ( { type: '__INERT__' } ) );
const barAction = jest.fn( () => ( { type: '__INERT__' } ) );
const store = createReduxStore( 'demo', {
reducer: ( state ) => state,
actions: {
foo: fooAction,
bar: barAction,
},
} );
registry.register( store );

const TestComponent = () => {
const { foo, bar } = useDispatch( store );
return (
<>
<button onClick={ foo }>foo</button>
<button onClick={ bar }>bar</button>
</>
);
};

render(
<RegistryProvider value={ registry }>
<TestComponent />
</RegistryProvider>
);

await user.click(
screen.getByRole( 'button', {
name: 'foo',
} )
);

expect( fooAction ).toBeCalledTimes( 1 );
expect( barAction ).toBeCalledTimes( 0 );

await user.click(
screen.getByRole( 'button', {
name: 'bar',
} )
);

expect( fooAction ).toBeCalledTimes( 1 );
expect( barAction ).toBeCalledTimes( 1 );
} );
} );