Performance Tests: --runInBand to avoid performance issues in CI environment #44905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
dmsnell
force-pushed
the
tests/run-perf-tests-in-band
branch
from
f33281e to
3aa1054
Compare
dmsnell
force-pushed
the
tests/run-perf-tests-in-band
branch
from
3aa1054 to
067b3cc
Compare
Member
Author
|
Closing because this change isn't significantly impacting the test run times either good or bad. After 50 experimental runs there is no statistical reason to believe this change impacts the test runtime. Assuming the test runs follow a normal distribution, then we approximate this branch to have N(2851s, 532s) and |
dmsnell
force-pushed
the
tests/run-perf-tests-in-band
branch
from
067b3cc to
052e429
Compare
|
Flaky tests detected in 052e429. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4129373690
|
…ronment Some projects have seen dramatic performance bottlenecks in CI environments because of the way `jest` parallelizes its test runs and bloats its memory usage. In this patch we're running the tests in serial to determine if this sequential-vs-parallel effect is in play in our GitHub Actions runs.
dmsnell
force-pushed
the
tests/run-perf-tests-in-band
branch
from
052e429 to
fe252cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore for now, this is for testing.
Does limiting test runs to
--runInBandreduce variation in measured metrics?