Skip to content

FontSizePicker: Update hint text to match the design #44966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 7 commits into from
Nov 2, 2022
Merged

FontSizePicker: Update hint text to match the design #44966

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e4b976
FontSizePicker: Update hint text to match the design
noisysocks Nov 1, 2022
14b4331
Add CustomSelectControl tests
noisysocks Nov 1, 2022
c069ae6
Add utils tests
noisysocks Nov 1, 2022
018894f
Update FontSizePicker tests
noisysocks Nov 1, 2022
07c4151
Update E2E tests
noisysocks Nov 1, 2022
5fc18a8
Update CHANGELOG.md
noisysocks Nov 2, 2022
1851fe5
Add __experimentalShowSelectedHint to storybook
noisysocks Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add CustomSelectControl tests
  • Loading branch information
@noisysocks
noisysocks committed Nov 2, 2022
commit 14b433159d5803169755e62069c39f8ed65a29fc
39 changes: 39 additions & 0 deletions packages/components/src/custom-select-control/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,43 @@ describe( 'CustomSelectControl', () => {

expect( onKeyDown ).toHaveBeenCalledTimes( 0 );
} );

it( 'does not show selected hint by default', () => {
render(
<CustomSelectControl
label="Custom select"
options={ [
{
key: 'one',
name: 'One',
__experimentalHint: 'Hint',
},
] }
__nextUnconstrainedWidth
/>
);
expect(
screen.getByRole( 'button', { name: 'Custom select' } )
).not.toHaveTextContent( 'Hint' );
} );

it( 'shows selected hint when __experimentalShowSelectedHint is set', () => {
render(
<CustomSelectControl
label="Custom select"
options={ [
{
key: 'one',
name: 'One',
__experimentalHint: 'Hint',
},
] }
__experimentalShowSelectedHint
__nextUnconstrainedWidth
/>
);
expect(
screen.getByRole( 'button', { name: 'Custom select' } )
).toHaveTextContent( 'Hint' );
} );
} );