-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Global styles: convert preset font size values to CSS vars #44967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ramonjd
merged 11 commits into
trunk
from
try/global-styles/use-css-var-font-size-preset
Nov 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6fce0f3
messing around seeing how we can use the preset slug + css var instea…
ramonjd 45c96f7
Fixed import and formatting
ramonjd 3795bfc
Create a new hook specifically for font size.
ramonjd 7d73c3a
Refactor useFontSizeStyleWithReset so that it exports named methods a…
ramonjd 6bcefe7
CHANGELOG.md update
ramonjd cb0b84b
Updated onChange mock arg expectations to include the second arg: fon…
ramonjd 7d469f2
Updating tests to include explicit args for mock onChange expectations
ramonjd 891dca4
Use find as an alternative to the deleted `getSelectedFontSize` metho…
ramonjd 09692b7
Now that we're setting font sizes using their presets we don't have t…
ramonjd b5f700c
Remove confusing comment, because it had nothing to do with the code …
ramonjd 9997012
Updating method name for clarity.
ramonjd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Create a new hook specifically for font size.
- Loading branch information
commit 3795bfc50c3bf9534eb8471d43019935188d6540
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.