Skip to content

PostPreviewButton: rewrite to functional, avoid state transitions in lifecycles #44971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 9 commits into from
Jul 10, 2023
Merged

PostPreviewButton: rewrite to functional, avoid state transitions in lifecycles #44971

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b9d188
PostPreviewButton: rewrite to functional, avoid state transitions in …
jsnajdr Oct 13, 2022
56f6c59
PreviewOptions: close dropdown after opening external preview
jsnajdr Oct 14, 2022
f524989
Move metaboxes save into a hook in savePost
jsnajdr Oct 19, 2022
92eda2f
Make isSavingPost true during entire save, not only when saving the e…
jsnajdr Oct 19, 2022
df7ff3e
Remove forceIsSaving and forcePreviewLink props: isSavingPost returns…
jsnajdr Oct 19, 2022
e00da35
Fix unit tests for isEditedPostAutosaveable and isSavingPost
jsnajdr Oct 20, 2022
69e8c5c
Fix PostPreviewButton unit tests
jsnajdr Oct 21, 2022
7376e29
Rename the action to editor.__unstableSavePost
jsnajdr Oct 21, 2022
df880bc
Remove the 'disabled when saving metaboxes' e2e test
jsnajdr Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make isSavingPost true during entire save, not only when saving the e… 
…ntity
  • Loading branch information
@jsnajdr
jsnajdr committed Jul 10, 2023
commit 92eda2f16ee3f59f8569e5c8c4e6505a97443e6f
22 changes: 5 additions & 17 deletions packages/editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,15 +681,9 @@ export function isDeletingPost( state ) {
*
* @return {boolean} Whether post is being saved.
*/
export const isSavingPost = createRegistrySelector( ( select ) => ( state ) => {
const postType = getCurrentPostType( state );
const postId = getCurrentPostId( state );
return select( coreStore ).isSavingEntityRecord(
'postType',
postType,
postId
);
} );
export function isSavingPost( state ) {
return !! state.saving.pending;
Copy link
Contributor

@youknowriad youknowriad Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My ultimate goal (probably never happens but who knows) is to make the editor package obsolete (because as an abstraction it's not clear). The change here goes in the opposite direction because it uses the store of this package. I think it's fine for now but I just wanted to share some thought on this.

Copy link
Member Author

@jsnajdr jsnajdr Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not just isSavingPost, but also adding a new functionality (the action hook) to the editor.savePost action goes in the opposite direction, too. When the savePost action moves somewhere else (to edit-post?), the isSavingPost selector and the state it reads will move as well.

}

/**
* Returns true if non-post entities are currently being saved, or false otherwise.
Expand Down Expand Up @@ -760,10 +754,7 @@ export const didPostSaveRequestFail = createRegistrySelector(
* @return {boolean} Whether the post is autosaving.
*/
export function isAutosavingPost( state ) {
if ( ! isSavingPost( state ) ) {
return false;
}
return Boolean( state.saving.options?.isAutosave );
return isSavingPost( state ) && Boolean( state.saving.options?.isAutosave );
}

/**
Expand All @@ -774,10 +765,7 @@ export function isAutosavingPost( state ) {
* @return {boolean} Whether the post is being previewed.
*/
export function isPreviewingPost( state ) {
if ( ! isSavingPost( state ) ) {
return false;
}
return Boolean( state.saving.options?.isPreview );
return isSavingPost( state ) && Boolean( state.saving.options?.isPreview );
}

/**
Expand Down