Edit Post: Refactor listener hook tests to RTL #45066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
30 tasks
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 18, 2022
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍 Another one bites the dust 🚀
| describe( 'useBlockSelectionListener', () => { | ||
| const registry = createRegistry( mockStores ); | ||
| const TestComponent = ( { postId } ) => { | ||
| useBlockSelectionListener( postId ); |
Member
There was a problem hiding this comment.
We could potentially create helpers for those and have them accept props so we don't have to declare almost the same boilerplate code in both tests, but I don't think this will help much. I'm more than happy to keep them as you suggested.
Member
Author
There was a problem hiding this comment.
The original test has a similar helper, but I find this more readable, and it only adds a few extra lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #44780.
This PR refactors the listener hook tests to use
@testing-library/reactinstead ofreact-test-rendererWhy?
It is a part of the recent effort to use
@testing-library/reactas the primary testing library.How?
We're simply rendering with RTL and updating the assertions to be better.
Testing Instructions