Table Block: Apply borders and padding on both front end and editor #45069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8.9 kB (+1%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
mikachan
changed the title
carolinan
approved these changes
Nov 3, 2022
Contributor
|
One question: Should these styles now be removed from the theme.scss file? |
Member
Author
Ah yeah, I think they should! There's no reason to duplicate them in the case where a theme opts into block-styles. |
carolinan
added
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
…45069) * Apply table borders on front end * Apply default cell padding to editor and front end * Remove padding and border from theme.scss
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
…45069) * Apply table borders on front end * Apply default cell padding to editor and front end * Remove padding and border from theme.scss
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR applies a default border to the front end of the Table Block, the same as the border style used in the editor. It also applies a default padding of
0.5emto the table cells, on both the front end and the editor.Before:
After:
Why?
Fixes #45065.
This makes the styles for the Table block consistent between the front end and the editor. The border styles can still be overwritten using the block settings in the editor.
I personally like showing the table border by default, as it makes it clear where the table cells are, and the user can choose to change or remove the border using the block settings. However, I'm not sure what the original reasoning was behind styling the table block this way, and if there perhaps needs to be more thought put into the default styles themselves.
How?
Uses the same line of CSS from the
editor.scssfile in thestyle.scssfile for the table block.Testing Instructions