Skip to content

Post editor: Rename view to Preview #45074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annezazu merged 1 commit into from
Oct 18, 2022
Merged

Post editor: Rename view to Preview #45074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/preview-options/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { check } from '@wordpress/icons';

export default function PreviewOptions( {
children,
viewLabel,
className,
isEnabled = true,
deviceType,
Expand All @@ -32,8 +33,7 @@ export default function PreviewOptions( {
variant: 'tertiary',
className: 'block-editor-post-preview__button-toggle',
disabled: ! isEnabled,
/* translators: button label text should, if possible, be under 16 characters. */
children: __( 'View' ),
children: viewLabel,
};
const menuProps = {
'aria-label': __( 'View options' ),
Expand Down
2 changes: 2 additions & 0 deletions packages/edit-post/src/components/device-preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ export default function DevicePreview() {
className="edit-post-post-preview-dropdown"
deviceType={ deviceType }
setDeviceType={ setPreviewDeviceType }
/* translators: button label text should, if possible, be under 16 characters. */
viewLabel={ __( 'Preview' ) }
>
{ isViewable && (
<MenuGroup>
Expand Down
2 changes: 2 additions & 0 deletions packages/edit-site/src/components/header-edit-mode/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ export default function Header( {
<PreviewOptions
deviceType={ deviceType }
setDeviceType={ setPreviewDeviceType }
/* translators: button label text should, if possible, be under 16 characters. */
viewLabel={ __( 'View' ) }
>
<MenuGroup>
<MenuItem
Expand Down