ToggleGroupControl: Remove invalid props from types#45114
Merged
Conversation
|
|
This was referenced Oct 19, 2022
ciampo
approved these changes
Oct 20, 2022
Contributor
ciampo
left a comment
There was a problem hiding this comment.
It's actually the first time that I see the FormElementProps type!
Anyway, nice finding! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #44168
What?
labelanddisabledprops picked from theFormElementPropstype.FormElementPropsutility type altogether.Why?
FormElementProps[ 'label' ]was marked as optional, and was overriding the explicitly requiredlabelprop defined inToggleGroupControlPropsitself.disabledprop in its current form.The
FormElementPropsis kind of unnecessary at the moment, so I think we should remove it for now.Testing Instructions
npm run storybook:devand see the props table for ToggleGroupControl. Thedisabledprop should be gone, and thelabelprop should now be correctly marked as required.