Conversation
chad1008
added
[Type] Bug
|
|
chad1008
force-pushed
the
fix/components-angle-picker-storybook-label-control
branch
from
63f4859 to
cb8dc81
Compare
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Contributor
|
Rebased in the hope that e2e checks will pass |
ciampo
force-pushed
the
fix/components-angle-picker-storybook-label-control
branch
from
cb8dc81 to
af1f8fc
Compare
ciampo
force-pushed
the
fix/components-angle-picker-storybook-label-control
branch
from
af1f8fc to
7b2006c
Compare
ciampo
reviewed
Oct 20, 2022
packages/components/CHANGELOG.md
Outdated
| - `withFocusReturn`: Refactor tests to `@testing-library/react` ([#45012](https://github.com/WordPress/gutenberg/pull/45012)). | ||
| - `ToolsPanel`: updated to satisfy `react/exhaustive-deps` eslint rule ([#45028](https://github.com/WordPress/gutenberg/pull/45028)) | ||
| - `Tooltip`: updated to ignore `react/exhaustive-deps` eslint rule ([#45043](https://github.com/WordPress/gutenberg/pull/45043)) | ||
| - `AnglePickerControl`: Set Storybook Label control type to 'text' ([#45122](https://github.com/WordPress/gutenberg/pull/45122)). |
Contributor
There was a problem hiding this comment.
We will need to move this to the Unreleased section of the changelog (this feedback applies to all currently open PRs)
ciampo
deleted the
fix/components-angle-picker-storybook-label-control
branch
Contributor
|
Failing React Native e2e tests are not related, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #45081
What?
Set AnglePickerControl Storybook Label Control type to text
Why?
Because this component isn't typed, Storybook was assuming this control would be an object, which caused a React error.
How?
Specifying the
argTypein the Story avoids the assumption by StorybookTesting Instructions
Launch Storybook locally and test the
AnglePickerControlcomponent.On the Controls tab, click the
Set Stringbutton for theLabelcontrolScreenshots or screencast