Skip to content

Hide block toolbar when spacing visualizer is showing #45131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 11 commits into from
Nov 3, 2022
Merged

Hide block toolbar when spacing visualizer is showing #45131

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae0de47
Add new store action/reducer/selector to indicate when the spacing vi…
glendaviesnz Oct 19, 2022
14d3aeb
Switch action/reducer wording to better identify what is happening
glendaviesnz Oct 20, 2022
696a77d
Add unit tests for reducer/selector
glendaviesnz Oct 24, 2022
af8b01c
Add action unit tests
glendaviesnz Oct 24, 2022
422e17f
Switch to a more generic 'isBlockInterfaceHidden' approach
glendaviesnz Oct 30, 2022
ec9f990
Stop propagation of mouse events in dimensions control so as not to f…
glendaviesnz Oct 30, 2022
3d7687c
Make the API experimental
glendaviesnz Nov 1, 2022
967e306
Remove experimental from reducer
glendaviesnz Nov 1, 2022
c43eacf
Fix unit test
glendaviesnz Nov 1, 2022
17015e4
Don't run the mouseovers if no value set or value is 0
glendaviesnz Nov 2, 2022
9b45382
Revert "Don't run the mouseovers if no value set or value is 0"
glendaviesnz Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add action unit tests
  • Loading branch information
@glendaviesnz
glendaviesnz committed Oct 24, 2022
commit af8b01cf547b0c94ff08c35ea660254f39f62c20
18 changes: 18 additions & 0 deletions packages/block-editor/src/store/test/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const noop = () => {};

const {
clearSelectedBlock,
hideBlockToolbar,
insertBlock,
insertBlocks,
mergeBlocks,
Expand All @@ -39,6 +40,7 @@ const {
replaceInnerBlocks,
resetBlocks,
selectBlock,
showBlockToolbar,
showInsertionPoint,
startMultiSelect,
startTyping,
Expand Down Expand Up @@ -775,6 +777,22 @@ describe( 'actions', () => {
} );
} );

describe( 'hideBlockToolbar', () => {
it( 'should return the HIDE_BLOCK_TOOLBAR action', () => {
expect( hideBlockToolbar() ).toEqual( {
type: 'HIDE_BLOCK_TOOLBAR',
} );
} );
} );

describe( 'showBlockToolbar', () => {
it( 'should return the SHOW_BLOCK_TOOLBAR action', () => {
expect( showBlockToolbar() ).toEqual( {
type: 'SHOW_BLOCK_TOOLBAR',
} );
} );
} );

describe( 'startTyping', () => {
it( 'should return the START_TYPING action', () => {
expect( startTyping() ).toEqual( {
Expand Down