Skip to content

Table Block: Add a deprecation for the figcaption element class name #45161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbravobernal merged 3 commits into from
Oct 21, 2022
Merged

Table Block: Add a deprecation for the figcaption element class name #45161

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c5efc4
Table Block: fix table deprecation
t-hamano Oct 20, 2022
fd7475e
Add comment
t-hamano Oct 21, 2022
48635ea
Add new fixture for the v3 deprecation
glendaviesnz Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@t-hamano
t-hamano committed Oct 21, 2022
commit fd7475eab8ad4523423654156f5b4d87e9ec9fb0
2 changes: 2 additions & 0 deletions packages/block-library/src/table/deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const oldColors = {
'subtle-pale-pink': '#fcf0ef',
};

// In #41140 support was added to global styles for caption elements which
// added a `wp-element-caption` classname to the embed figcaption element.
const v3 = {
Copy link
Contributor

@glendaviesnz glendaviesnz Oct 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restructuring this into a named version format - it makes it much easier to work with the deprecations this way. It would be good to add a comment above the v3 to outline the reason for the deprecation:

// In #41140 support was added to global styles for caption elements which added a `wp-element-caption` classname to the embed figcaption element.

this hasn't been common practice in the past, but it helps when looking at deprecations at a glance to work out what they cover.

Copy link
Contributor Author

@t-hamano t-hamano Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review, done!

attributes: {
hasFixedLayout: {
Expand Down