GH-39602 | Change label for adding inner-block button.

[koneweczka]

What?

Inner blocks have their own label for button. The name is generic.

Why?

To differ adding blocks (like navigation, columns, etc.) and inner blocks (items inside this blocks) according to this issue.

How?

Now inner blocks have generic label"Add new item" instead of "Add block".

Testing Instructions

1. Add some blocks with inner block (columns, navigation, etc.)
2. Label for it should be "Add new item".
3. Label for regular block should still be "Add block".

Screenshots or screencast

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @koneweczka! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[alexstine]

@koneweczka Thanks for the PR. One thought below.

[alexstine]

This label is still generic. From an accessibility standpoint, it would be nice to hear what I am adding to what. It seems like it would make more sense to have something like this.

label = sprintf( _x( 'Add block to %s' ), parent_block_title );

Not sure how hard this would be to implement, but seems worth the time if we're already here.

[Mamaduka]

Thanks for contributing, @koneweczka!

Closing this as "won't fix" for the moment. The ButtonBlockAppender is a generic component and can be rendered in various contexts.

A better labeling is probably better discussed in a separate issue.