Disabled: Improve TypeScript code after recent refactor to inert #45252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
reviewed
Oct 25, 2022
| * @param {Object} config Configuration object. | ||
| * @param {boolean=} config.isDisabled Whether the element should be disabled. | ||
| * @return {import('react').RefCallback<HTMLElement>} Element Ref. | ||
| * @param config Configuration object. |
Member
There was a problem hiding this comment.
We still need the types here, don't we? The docs build script was failing because of missing param types.
I just pushed a commit to restore them, but let me know if this had some special purpose.
Contributor
Author
There was a problem hiding this comment.
Nice catch! We usually remove JSDoc types when we add the TypeScript ones, but in this case it looks like they have to be kept around for the docgen — TIL!
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cleanup code after recent changes in #44865
Why?
We should try to avoid using
@ts-ignorecomments when possible.In the case of the unit tests, those comments where not necessary thanks to this refactor by @tyxla #44930
How?
Testing Instructions
Screenshots or screencast