Skip to content

FontSizePicker: Rewrite unit tests to use userEvent and be more comprehensive #45298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 12 commits into from
Nov 1, 2022
Merged

FontSizePicker: Rewrite unit tests to use userEvent and be more comprehensive #45298

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
299d680
Rewrite FontSizePicker unit tests to use userEvent and be more compre…
noisysocks Oct 26, 2022
b0314d2
Use header label's aria-label
noisysocks Oct 28, 2022
c2b4da6
Put back the Gigantosaurus 🦖
noisysocks Oct 28, 2022
d6c4d65
Update changelog
noisysocks Oct 28, 2022
9b9fc00
Merge branch 'trunk' into update/font-size-picker-unit-tests
noisysocks Oct 28, 2022
a939507
Remove editorialising comment
noisysocks Oct 31, 2022
22c9ab3
Use getByLabelText( 'Custom Size' ) to select slider
noisysocks Oct 31, 2022
8a0fc89
Remove redundant test
noisysocks Oct 31, 2022
1673ba3
Add tests for non-px font sizes
noisysocks Nov 1, 2022
ab89dde
Assert length of options/radios
noisysocks Nov 1, 2022
4032f0f
Assert number of calls to onChange
noisysocks Nov 1, 2022
091aeea
Merge branch 'trunk' into update/font-size-picker-unit-tests
noisysocks Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove editorialising comment
  • Loading branch information
@noisysocks
noisysocks committed Oct 31, 2022
commit a93950724835e76df452911691212429a5e858f6
2 changes: 0 additions & 2 deletions packages/components/src/font-size-picker/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,6 @@ describe( 'FontSizePicker', () => {
const sliderInput = document.querySelector(
'.components-range-control__slider'
);
// Fake the slider drag using fireEvent. Testing drag-and-drop using
// userEvent is a job for the RangeControl tests.
fireEvent.change( sliderInput!, {
target: { value: 80 },
} );
Expand Down