Skip to content

Add a minHeight block support under dimensions #45300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 11 commits into from
Nov 3, 2022
+687 −31
Merged

Add a minHeight block support under dimensions #45300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3ed6b83
Try: Add a minHeight block support under dimensions
andrewserong Oct 26, 2022
7d20842
Fix linting issues
andrewserong Oct 26, 2022
57d0cac
Fix up order and skipSerialization
andrewserong Oct 27, 2022
b74f495
Fix linting issue
andrewserong Oct 31, 2022
2a0a1ca
Set UnitControl components to use full large height
andrewserong Oct 31, 2022
848420a
Fix bad rebase
andrewserong Nov 2, 2022
a9b483c
Fix return of dimensions support in PHP
andrewserong Nov 2, 2022
e268c26
Remove duplicate spread of dimensions
andrewserong Nov 2, 2022
102e0f4
Add PHP tests
andrewserong Nov 2, 2022
ba6bb83
Rename to Min. height
andrewserong Nov 2, 2022
cdb9adf
Switch position of min height control so that it is at the bottom of …
andrewserong Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up order and skipSerialization
  • Loading branch information
@andrewserong
andrewserong committed Nov 3, 2022
commit 57d0cac81ac2ed21fbf7c308fd1ad20897b7c2c8
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.2/class-wp-theme-json-6-2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ class WP_Theme_JSON_6_2 extends WP_Theme_JSON_6_1 {
array( 'border', 'radius' ),
array( 'border', 'style' ),
array( 'border', 'width' ),
array( 'dimensions', 'minHeight' ),
array( 'color', 'link' ),
array( 'dimensions', 'minHeight' ),
array( 'spacing', 'blockGap' ),
array( 'spacing', 'margin' ),
array( 'spacing', 'padding' ),
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const skipSerializationPathsEdit = {
[ `${ TYPOGRAPHY_SUPPORT_KEY }.__experimentalSkipSerialization` ]: [
TYPOGRAPHY_SUPPORT_KEY,
],
[ `${ SPACING_SUPPORT_KEY }.__experimentalSkipSerialization` ]: [
[ `${ DIMENSIONS_SUPPORT_KEY }.__experimentalSkipSerialization` ]: [
DIMENSIONS_SUPPORT_KEY,
],
[ `${ SPACING_SUPPORT_KEY }.__experimentalSkipSerialization` ]: [
Expand Down