Skip to content

[WIP] Sidebar: Allow individual blocks to define default tab #45304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronrobertshaw wants to merge 2 commits into from
Closed

[WIP] Sidebar: Allow individual blocks to define default tab #45304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dd9e46
Make block inspector accept default tab from block type
aaronrobertshaw Oct 26, 2022
ad4b40f
Set default tabs for paragraph, nav & query blocks
aaronrobertshaw Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make block inspector accept default tab from block type
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Oct 26, 2022
commit 0dd9e460d0febecc078ce8af1e419fbe3ef45b36
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/inspector-controls-tabs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* WordPress dependencies
*/
import { hasBlockSupport } from '@wordpress/blocks';
import { getBlockType, hasBlockSupport } from '@wordpress/blocks';
import {
PanelBody,
TabPanel,
Expand Down Expand Up @@ -115,11 +115,15 @@ export default function InspectorControlsTabs( {
}
}

const blockType = getBlockType( blockName );

// We have multiple tabs with contents so render complete TabPanel.
return (
<TabPanel
className="block-editor-block-inspector__tabs"
tabs={ availableTabs }
initialTabName={ blockType.defaultTab }
key={ clientId }
Copy link
Copy Markdown
Contributor Author

@aaronrobertshaw aaronrobertshaw Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to better approaches here to force the tab panel to reflect different block types' default tabs.

>
{ ( tab ) => {
if ( tab.name === TAB_MENU.name ) {
Expand Down