React Native unit tests: migrate getByA11yLabel usages #45454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
update/rn-tests-a11y-labels
branch
from
bfb49a4 to
dd0dd4e
Compare
geriux
approved these changes
Nov 3, 2022
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making these changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@testing-library/react-nativepackage, version 10.0, removes thegetByA11yLabelquery methods (and their siblings likefind*orqueryAll*). They were aliases ofgetByLabelTextmethods, which are the only variant that continues to be supported.This PR migrates all usages of
ByA11yLabeltoByLabelText. They are aliases, there's no behavior change. We're doing this in preparation to upgrade the library from currently used 9.x to the latest 11.x.See also:
ByA11yLabelaliases@testing-library/react-nativeversion 10.0.0Part of React 18 migration in #45235.