-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Colorize template parts and Reusable blocks #45473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7d47273
9204830
c26150b
27e1cf5
1ab8214
93bf9ba
2a3deca
22c5977
be58817
0d1dbb9
3fbf88d
3e0d7f0
bc38da3
e0f5905
6931586
e5d1f96
00abab3
a28dd85
878ae16
a9d1848
31a7b11
d4e1e7d
00846fb
e93470d
d50750c
8fb97dd
2333a27
0ea11cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import classnames from 'classnames'; | ||
|
|
||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
|
|
@@ -17,6 +22,7 @@ function BlockCard( { | |
| blockType, | ||
| parentBlockClientId, | ||
| handleBackButton, | ||
| isSynced, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would make better to add
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea - I will take a look at that tomorrow. |
||
| } ) { | ||
| if ( blockType ) { | ||
| deprecated( '`blockType` property in `BlockCard component`', { | ||
|
|
@@ -30,7 +36,11 @@ function BlockCard( { | |
| window?.__experimentalEnableOffCanvasNavigationEditor === true; | ||
|
|
||
| return ( | ||
| <div className="block-editor-block-card"> | ||
| <div | ||
| className={ classnames( 'block-editor-block-card', { | ||
| 'is-synced': isSynced, | ||
| } ) } | ||
| > | ||
| { isOffCanvasNavigationEditorEnabled && parentBlockClientId && ( | ||
| <Button | ||
| onClick={ handleBackButton } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is the best place to put these - went with CSS vars instead of SCSS vars so themes can potentially override these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The choice of CSS vars over SCSS makes sense to me 👍