Lodash: Simplify a few isEmpty calls
#45525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
dcalhoun,
enejb,
fluiddot,
geriux,
jd-alexander and
pinarol
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Member
Author
|
Hey team, could anyone take a look? I was left with the impression these are pretty straightforward to review. |
Member
|
Hey there 👋 I have it on my list to review it today! Sorry for the delay 😅 |
Member
Author
|
Ah, thanks a ton in advance @geriux 🙌 |
geriux
approved these changes
Nov 21, 2022
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! I tested this on an iPhone 14 Pro with VoiceOver. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes a few
_.isEmpty()in favor of simpler checks.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing a few usages with a simple native
! stringcheck when we're dealing with strings. The good thing about that new way is that it will catchundefinedandnullas well, so it's a pretty safe change.Testing Instructions
On native: