Global Styles: Re-add styles that were removed, for classic themes #45570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
fix #44659.
Add the styles removed in 6.1 to the CSS for the classic theme
Styles were removed in this pull request.
#43553
This pull request restored some of the styles, but left some colors removed, such as hover.
#44334
Why?
How?
Testing Instructions
The hover color should be white.
The color when hovered should be red
The classic.scss is managed in the gutenberg repository, but I could not tell if the styles are reflected without overwriting the core stylesheet in my environment.
So perhaps the styles will be reflected when they are merged into the core.
I'm putting it out there in the sense of adding styles to classic.scss in this pull request.
Screenshots or screencast