Skip to content

NavigationToggle: wait for tooltip positioning in unit test #45587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsnajdr wants to merge 3 commits into from
Closed

NavigationToggle: wait for tooltip positioning in unit test #45587

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd5c517
NavigationToggle: wait for tooltip positioning in unit test
jsnajdr Nov 7, 2022
ee016bb
Try with a custom matcher
tyxla Nov 8, 2022
b81f2ff
Update waitFor timeout option to interval
jsnajdr Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update waitFor timeout option to interval
  • Loading branch information
@jsnajdr
jsnajdr committed Nov 9, 2022
commit b81f2ff0df38d33d9086e6d610170096ad925855
4 changes: 2 additions & 2 deletions packages/edit-site/src/components/navigation-sidebar/navigation-toggle/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe( 'NavigationToggle', () => {
expect(
screen.getByText( 'Toggle navigation' ).parentElement
).toBePositioned(),
{ timeout: 2000 } // It might take more than a second to position the popover.
{ interval: 10 } // It takes many microtask tick to position the popover.
);

const siteIcon = screen.getByAltText( 'Site Icon' );
Expand Down Expand Up @@ -126,7 +126,7 @@ describe( 'NavigationToggle', () => {
expect(
screen.getByText( 'Toggle navigation' ).parentElement
).toBePositioned(),
{ timeout: 2000 } // It might take more than a second to position the popover.
{ interval: 10 } // It takes many microtask tick to position the popover.
);

expect(
Expand Down