TabPanel: fix the exhaustive-deps warning#45660
Merged
Conversation
|
|
44 tasks
ciampo
added
[Type] Code Quality
ciampo
changed the title
handleTabSelection to the list of hook deps to fix the exhaustive-deps warningexhaustive-deps warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix the
exhaustive-depswarning in theTabPanelcomponentRelated to:
TabPanelto passexhaustive-deps#44935 (a previous attempt at fixing theexhaustive-depswarning)TabPanelhook)Why?
Because #41166
How?
handleTabSelectionto the list ofuseEffectdependencieshandleTabSelectioninuseCallbackTesting Instructions
handleTabSelectionto fire more often than before — when smoke testing, pay particular attention to consumers ofTabPanelpassing theonSelectprop, and how frequently theonSelectcallback gets called after the changes from this PR.