[WP6.1.1] AutoComplete: Revert to event.keyCode to fix IME composition issue
#45704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +34 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mirka
approved these changes
Nov 10, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Thank you!
Working as expected on Mac Chrome/Firefox/Safari 👍
Member
t-hamano
added
[Package] Components
Mamaduka
added
Backport to WP Minor Release
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is backported to WP6.1.1 and reverts
event.codetoevent.keyCode, one of the changes made toAutoCompletein #43432.This separate PR #45626 / #45510 will be applied to Gutenberg's latest trunk.
Why?
The background behind the creation of this PR can be found after the comments here.