useBaseField: Convert component to TypeScript#45712
Merged
Conversation
walbo
added
[Type] Code Quality
|
|
walbo
changed the title
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
ciampo
reviewed
Nov 12, 2022
ciampo
reviewed
Nov 16, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Thank you for iterating on this! I gave it another look and left a couple more comments (sorry for not noticing before!)
Contributor
|
Hey @walbo , let me know if you don't have capacity to work on this, and I'll be happily take over :) |
Member
Author
|
Hi @ciampo Yes, I'm a bit busy with other commitments the next couple of weeks so if you don’t mind I would appreciate if you could land this one 👍 Thanks |
Contributor
|
Absolutely, no issues! Thank you anyway for starting the work on this one! |
ciampo
force-pushed
the
refactor/base-field-to-typescript
branch
from
93b3f4e to
dc1ffdc
Compare
ciampo
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
useBaseFieldcomponent to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Testing Instructions
npm run devand ensure no typing errorsnpm run test:unit -- packages/components/src/base-fieldand make sure unit tests passes.