Skip to content

Dashicon: refactor to TypeScript #45924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 5 commits into from
Dec 5, 2022
Merged

Dashicon: refactor to TypeScript #45924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1d20fb
Dashicon: refactor to TypeScript
hideokamoto Nov 20, 2022
85fbbe0
chore: fix the type definision on the Dashicon component
hideokamoto Nov 29, 2022
e1cd42b
chore: remove unuse typedef on the Dashicon component
hideokamoto Dec 3, 2022
0bce7b2
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into r…
hideokamoto Dec 3, 2022
ced35b4
chore: update the changelog on packages/components
hideokamoto Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix the type definision on the Dashicon component
  • Loading branch information
@hideokamoto
hideokamoto committed Nov 29, 2022
commit 85fbbe060fcd30a1552934f035ad7991b8e25aa1
8 changes: 2 additions & 6 deletions packages/components/src/dashicon/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,16 @@
/**
* Internal dependencies
*/
import type { WordPressComponentProps } from '../ui/context';
import type { DashiconProps } from './types';

/**
* @param {Props} props
* @return {JSX.Element} Element
*/

function Dashicon( {
icon,
className,
size = 20,
style = {},
...extraProps
}: DashiconProps ) {
}: WordPressComponentProps< DashiconProps, 'span', false > ) {
const iconClass = [
'dashicon',
'dashicons',
Expand Down
18 changes: 12 additions & 6 deletions packages/components/src/dashicon/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
/**
* External dependencies
*/
import type { ComponentPropsWithoutRef } from 'react';

export type DashiconProps = {
/**
* The icon name
*/
icon: IconKey;

/**
* Class name
*/
className?: string;

/**
* Size of the icon
*/
size?: number;
} & ComponentPropsWithoutRef< 'span' >;
};

export type IconKey =
| 'admin-appearance'
Expand Down