Skip to content

Merged data should consider origin to return early #45969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 15 commits into from
Nov 25, 2022
Merged

Merged data should consider origin to return early #45969

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f2b0c16
Bail early for given origin
oandregal Nov 22, 2022
4683653
Remove method from experimental, it is stable
oandregal Nov 24, 2022
1eabb78
Only call set spacing presets when necessary
oandregal Nov 24, 2022
845495d
Add test coverage per origin
oandregal Nov 24, 2022
3a5602a
Add blocks origin test and improve them all
oandregal Nov 24, 2022
60ec9b7
Extract utility functions
oandregal Nov 24, 2022
40bb25c
Improve block styles check
oandregal Nov 24, 2022
795319a
Clean cached data
oandregal Nov 24, 2022
6865e70
Fix lint issues
oandregal Nov 24, 2022
1de4692
Add the spacing sizes generation back in before final return
glendaviesnz Nov 24, 2022
3b0e7bf
Update phpunit/class-wp-theme-json-resolver-test.php
oandregal Nov 25, 2022
75c1202
Fix suggestions
oandregal Nov 25, 2022
7228291
Use data provider in test
oandregal Nov 25, 2022
6d06e33
Inline utility functions
oandregal Nov 25, 2022
07903d3
Fix lint issues
oandregal Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve block styles check
  • Loading branch information
@oandregal
oandregal committed Nov 24, 2022
commit 40bb25c46524597bcf16b648c011f6e218607a96
20 changes: 16 additions & 4 deletions phpunit/class-wp-theme-json-resolver-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,10 @@ public function test_get_merged_data_returns_origin_default() {
$settings = $theme_json->get_settings();
$styles = $theme_json->get_styles_block_nodes();
$this->assertTrue( isset( $settings['color']['palette']['default'] ), 'core palette is present' );
$this->assertFalse( isset( $styles[4] ) , 'block styles are not present' );
$block_styles = array_filter( $styles, function( $element ) {
return isset( $element['name'] ) && $element['name'] === 'my/block-with-styles';
} );
$this->assertTrue( count( $block_styles ) === 0 , 'block styles are not present' );
$this->assertFalse( isset( $settings['color']['palette']['theme'] ), 'theme palette is not present' );
$this->assertFalse( isset( $settings['color']['palette']['custom'] ), 'user palette is not present' );

Expand All @@ -439,7 +442,10 @@ public function test_get_merged_data_returns_origin_blocks() {
$settings = $theme_json->get_settings();
$styles = $theme_json->get_styles_block_nodes();
$this->assertTrue( isset( $settings['color']['palette']['default'] ), 'core palette is present' );
$this->assertSame( $styles[4]['name'], 'my/block-with-styles' , 'block styles are present' );
$block_styles = array_filter( $styles, function( $element ) {
return isset( $element['name'] ) && $element['name'] === 'my/block-with-styles';
} );
$this->assertTrue( count( $block_styles ) === 1 , 'block styles are present' );
$this->assertFalse( isset( $settings['color']['palette']['theme'] ), 'theme palette is not present' );
$this->assertFalse( isset( $settings['color']['palette']['custom'] ), 'user palette is not present' );

Expand All @@ -463,7 +469,10 @@ public function test_get_merged_data_returns_origin_theme() {
$settings = $theme_json->get_settings();
$styles = $theme_json->get_styles_block_nodes();
$this->assertTrue( isset( $settings['color']['palette']['default'] ), 'core palette is present' );
$this->assertSame( $styles[4]['name'], 'my/block-with-styles' , 'block styles are present' );
$block_styles = array_filter( $styles, function( $element ) {
return isset( $element['name'] ) && $element['name'] === 'my/block-with-styles';
} );
$this->assertTrue( count( $block_styles ) === 1 , 'block styles are present' );
$this->assertTrue( isset( $settings['color']['palette']['theme'] ), 'theme palette is present' );
$this->assertFalse( isset( $settings['color']['palette']['custom'] ), 'user palette is not present' );

Expand All @@ -487,7 +496,10 @@ public function test_get_merged_data_returns_origin_custom() {
$settings = $theme_json->get_settings();
$styles = $theme_json->get_styles_block_nodes();
$this->assertTrue( isset( $settings['color']['palette']['default'] ), 'core palette is present' );
$this->assertSame( $styles[4]['name'], 'my/block-with-styles' , 'block styles are present' );
$block_styles = array_filter( $styles, function( $element ) {
return isset( $element['name'] ) && $element['name'] === 'my/block-with-styles';
} );
$this->assertTrue( count( $block_styles ) === 1 , 'block styles are present' );
$this->assertTrue( isset( $settings['color']['palette']['theme'] ), 'theme palette is present' );
$this->assertTrue( isset( $settings['color']['palette']['custom'] ), 'user palette is present' );

Expand Down