Skip to content

Blocks: Handle pressing backspace at the beginning of blocks #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 9 commits into from
Apr 27, 2017
Merged

Blocks: Handle pressing backspace at the beginning of blocks #461

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e4945d
Blocks: Handle the backspace at the beginning of blocks
youknowriad Apr 20, 2017
7106128
replacing `childNodes[ 0 ]` with `firstChild`
youknowriad Apr 24, 2017
d5fc22a
Element: Rename concatChildren helper and add unit tests
youknowriad Apr 25, 2017
f0c34ba
Style: avoid ternary and fallback using ||
youknowriad Apr 25, 2017
ae4f41a
Fix merging two consecutive empty headings
youknowriad Apr 26, 2017
15b70c1
Fix TinyMCE isCollapsed error when merging two blocks
youknowriad Apr 26, 2017
129ffd7
Stop keydown event propagation if editor removed by merge
aduth Apr 26, 2017
1b360dc
Update concatChildren to accomodate multiple children
youknowriad Apr 27, 2017
a2c1065
ConcatChildren: Fix unit tests
youknowriad Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix TinyMCE isCollapsed error when merging two blocks
  • Loading branch information
@youknowriad
youknowriad committed Apr 27, 2017
commit 15b70c1cf2c315f4e9db44beda2b9743c078587d
5 changes: 3 additions & 2 deletions blocks/components/editable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,10 @@ export default class Editable extends wp.element.Component {

onKeyDown( event ) {
if ( this.props.onMerge && event.keyCode === KEYCODE_BACKSPACE && this.isStartOfEditor() ) {
Copy link
Member

@aduth aduth Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it was intentional, but nice optimization having the heaviest part of the condition performed last and taking advantage of short-circuiting 👍

Copy link
Contributor Author

@youknowriad youknowriad Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional :)

event.preventDefault();
this.onChange();
this.props.onMerge( this.editor.getContent() );

// Debouncing this call avoids TinyMCE error while handling `keydown` event
setTimeout( () => this.props.onMerge( this.editor.getContent() ) );
}
}

Expand Down