Skip to content

Design Tools: Add a Position block support (including sticky), decoupled from layout #46142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 13 commits into from
Jan 10, 2023
Merged

Design Tools: Add a Position block support (including sticky), decoupled from layout #46142

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f485b89
Try: Add Position support, decoupled from Layout
andrewserong Nov 29, 2022
4b5b03b
Try a CustomSelectControl for the position input
andrewserong Dec 1, 2022
994743d
Try moving the control to a separate Position PanelBody
andrewserong Dec 2, 2022
95d1c67
Add Position group, ensure Position panel always appears just before …
andrewserong Dec 5, 2022
9148c63
Roll in fix for toolbar position
andrewserong Dec 15, 2022
b4053c8
Remove no longer needed change to block popover
andrewserong Jan 4, 2023
3fccfe4
Add scrollContainer to deps array
andrewserong Jan 4, 2023
db57fef
Remove redundant PHP code
andrewserong Jan 5, 2023
218acc2
Switch Static to Default, display help text after selection, update text
andrewserong Jan 6, 2023
3f7f8f2
Remove help text, update logic to gracefully handle illegal values
andrewserong Jan 9, 2023
8eeb233
Try ensuring sticky/fixed blocks always flip the toolbar position
andrewserong Jan 9, 2023
911771f
Ensure position UI and style output is only applied on themes that su…
andrewserong Jan 10, 2023
a96933f
Clarify TODO comment for z-index values
andrewserong Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add scrollContainer to deps array
  • Loading branch information
@andrewserong
andrewserong committed Jan 4, 2023
commit 3fccfe498e0c669be72d552254748f137bf3309c
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-tools/use-block-toolbar-popover-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export default function useBlockToolbarPopoverProps( {
toolbarHeight
)
),
[ contentElement, selectedBlockElement, toolbarHeight ]
[ contentElement, selectedBlockElement, scrollContainer, toolbarHeight ]
);

// Update props when the block is moved. This also ensures the props are
Expand Down