Skip to content

Fix auto Nav menu creation due to page list inner blocks #46223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 11 commits into from
Dec 6, 2022
+60 −7
Merged

Fix auto Nav menu creation due to page list inner blocks #46223

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9a8ad06
Add exception for page list to ignore its inner blocks
getdave Dec 1, 2022
34bf73e
Explain what is going on
getdave Dec 1, 2022
1f65661
Only consider the first block
getdave Dec 1, 2022
1a6d06d
Remove debugging
getdave Dec 5, 2022
44149e1
Be specific in the referential equality check comments
getdave Dec 5, 2022
f4bfc53
Ditch Lodash for Fast Deep Equal
getdave Dec 6, 2022
4c3f1f5
Use customised conditional deep equality
getdave Dec 6, 2022
bd9393f
Remove unnecessary let
getdave Dec 6, 2022
7cd3925
Add comments for context
getdave Dec 6, 2022
94743d2
Fix grammar
getdave Dec 6, 2022
ec45184
Target fix to Page List only
getdave Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ditch Lodash for Fast Deep Equal
  • Loading branch information
@getdave
getdave committed Dec 6, 2022
commit f4bfc534c573f88cc47d6a71f476431905dd13f4
4 changes: 2 additions & 2 deletions packages/block-library/src/navigation/edit/unsaved-inner-blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { isEqual } from 'lodash';
import fastDeepEqual from 'fast-deep-equal/es6';

/**
* WordPress dependencies
Expand Down Expand Up @@ -85,7 +85,7 @@ export default function UnsavedInnerBlocks( {
...currentPageListBlockWithoutInnerBlocks
} = currentPageListBlock;

innerBlocksAreDirty = ! isEqual(
innerBlocksAreDirty = ! fastDeepEqual(
originalPageListBlockWithoutInnerBlocks,
currentPageListBlockWithoutInnerBlocks
);
Expand Down