Skip to content

Block Editor: Fix some usages of useSelect that return unstable results #46226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 3 commits into from
Dec 1, 2022
Merged

Block Editor: Fix some usages of useSelect that return unstable results #46226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
483c3dc
UngroupButton: return stable innerBlocks value
jsnajdr Dec 1, 2022
06fed75
getBlockTransformItems: fix params for the dependants function
jsnajdr Dec 1, 2022
2304158
BlockActionsMenu: pass bare selectedBlock to getBlockTransformItems t…
jsnajdr Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
getBlockTransformItems: fix params for the dependants function
  • Loading branch information
@jsnajdr
jsnajdr committed Dec 1, 2022
commit 06fed757097ac543b85acaf043f91216e3c76ea0
2 changes: 1 addition & 1 deletion packages/block-editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,7 +2107,7 @@ export const getBlockTransformItems = createSelector(
'desc'
);
},
( state, rootClientId ) => [
( state, blocks, rootClientId ) => [
Copy link
Member

@tyxla tyxla Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

state.blockListSettings[ rootClientId ],
state.blocks.byClientId,
state.preferences.insertUsage,
Expand Down