Skip to content

Site Editor: Move the edit button on top of the frame #46272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youknowriad wants to merge 3 commits into from
Closed

Site Editor: Move the edit button on top of the frame #46272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f5796
Site Editor: Move the edit button on top of the frame
youknowriad Dec 2, 2022
fd39f04
Reduce the size of the edit button
youknowriad Dec 2, 2022
fba1c77
fix e2e tests
youknowriad Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce the size of the edit button
  • Loading branch information
@youknowriad
youknowriad committed Dec 2, 2022
commit fd39f0400dcee527ae8a8bedb72078833968a700
1 change: 1 addition & 0 deletions packages/edit-site/src/components/layout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ export default function Layout( { onError } ) {
alignment="right"
>
<Button
className="edit-site-layout__edit-button-canvas-header"
isPrimary
label={ __( 'Open the editor' ) }
onClick={ () => {
Expand Down
11 changes: 6 additions & 5 deletions packages/edit-site/src/components/layout/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@
position: relative;
flex-grow: 1;
z-index: 2;

.edit-site-layout:not(.is-full-canvas) & {
padding-top: $grid-unit-10;
}
}

.edit-site-layout__canvas {
Expand Down Expand Up @@ -118,13 +114,18 @@

.edit-site-layout.is-editor-page:not(.is-full-canvas) & {
@include break-small {
top: $button-size + $grid-unit-20;
top: $header-height;
}
}
}

.edit-site-layout__canvas-header {
padding-right: $canvas-padding;
height: $header-height;
}

.edit-site-layout__edit-button-canvas-header {
height: 32px;
}

// This shouldn't be necessary (we should have a way to say that a skeletton is relative
Expand Down