[Site Editor]: Add default white background for themes with no background color set
#46314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
jameskoster,
jasmussen,
t-hamano and
youknowriad
|
Size Change: +1 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jameskoster
reviewed
Dec 5, 2022
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Seems to be working for me :)
jameskoster
approved these changes
Dec 5, 2022
Member
|
Adjusting this in #46752. |
Member
|
Mentioning that this breaks really easily if the load order of CSS changes. We are running Gutenberg in an environment where CSS is concatenated, which results in a blank white site editor. (see Automattic/wp-calypso#71679) We fixed that by removing this change from our deployment of Gutenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #46291
Testing Instructions
emptytheme or a theme which doesn't set the background coloreditoriswhitewhite.Notes
In some places it might make some time to apply the default color and that is because the css rule is applied to the iframe and needs to load. I tried at first to update in an
uppernode, but it's used in more places where we do rely on the dark color. Of course any suggestion for better placement is welcome.