Skip to content

Navigation: Add a 'open list view' button #46335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scruffian merged 5 commits into from
Dec 12, 2022
Merged

Navigation: Add a 'open list view' button #46335

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63cf468
Navigation: Add a 'open list view' button
scruffian Dec 6, 2022
5670239
Remove invalid comment
scruffian Dec 7, 2022
914bc42
Update packages/edit-post/src/plugins/navigation-list-view-menu-item.js
scruffian Dec 7, 2022
e059227
Remove the <BlockTools component
scruffian Dec 9, 2022
8000335
formatting change
scruffian Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the <BlockTools component
  • Loading branch information
@scruffian
scruffian committed Dec 9, 2022
commit e059227321955f20373aeaa629470dd7c38e5960
25 changes: 10 additions & 15 deletions packages/edit-post/src/plugins/navigation-list-view-menu-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
/**
* WordPress dependencies
*/
import {
import {
BlockEditorProvider,
BlockTools,
__unstableBlockToolbarLastItem,
__unstableBlockNameContext,
} from '@wordpress/block-editor';
import { ToolbarButton, ToolbarGroup } from '@wordpress/components';
import { useDispatch } from '@wordpress/data';
import { Fragment } from '@wordpress/element';
import { ReusableBlocksMenuItems } from '@wordpress/reusable-blocks';
import { __ } from '@wordpress/i18n';
import { listView } from '@wordpress/icons';

Expand Down Expand Up @@ -42,18 +40,15 @@ if ( isOffCanvasNavigationEditorEnabled ) {
const NavigationEditMenuItem = () => {
return (
<BlockEditorProvider>
<BlockTools>
<__unstableBlockToolbarLastItem>
<__unstableBlockNameContext.Consumer>
{ ( blockName ) =>
blockName === 'core/navigation' && (
<MaybeNavMenuSidebarToggle />
)
}
</__unstableBlockNameContext.Consumer>
</__unstableBlockToolbarLastItem>
</BlockTools>
<ReusableBlocksMenuItems />
<__unstableBlockToolbarLastItem>
<__unstableBlockNameContext.Consumer>
{ ( blockName ) =>
blockName === 'core/navigation' && (
<MaybeNavMenuSidebarToggle />
)
}
</__unstableBlockNameContext.Consumer>
</__unstableBlockToolbarLastItem>
</BlockEditorProvider>
);
};
Expand Down