Skip to content

[RNMobile] Temporarily skip failing copy/paste tests #46340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SiobhyB merged 1 commit into from
Dec 7, 2022
Merged

[RNMobile] Temporarily skip failing copy/paste tests #46340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native-editor/__device-tests__/gutenberg-editor-drag-and-drop.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ import {
} from './helpers/utils';
import testData from './helpers/test-data';

// Used to skip some tests on iOS
const onlyOnAndroid = isAndroid() ? it : it.skip;
// Tests associated with this const are temporarily off for both platforms due to failures.
// They should be enabled for Android-only when a fix is in place.
const onlyOnAndroid = it.skip;
Comment on lines +15 to +17
Copy link
Contributor

@fluiddot fluiddot Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB @derekblank I feel it can be a bit misleading that we keep calling the constant onlyOnAndroid when we are skipping the test on both platforms 😅. Maybe we could directly use it.skip on those tests and add this comment as a reference that we'll re-enable them in the future when we provide a fix.


describe( 'Gutenberg Editor Drag & Drop blocks tests', () => {
beforeEach( async () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-editor/__device-tests__/gutenberg-editor-paste.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe( 'Gutenberg Editor paste tests', () => {
await clearClipboard( editorPage.driver );
} );

it( 'copies plain text from one paragraph block and pastes in another', async () => {
it.skip( 'copies plain text from one paragraph block and pastes in another', async () => {
await editorPage.addNewBlock( blockNames.paragraph );
const paragraphBlockElement = await editorPage.getTextBlockAtPosition(
blockNames.paragraph
Expand Down Expand Up @@ -68,7 +68,7 @@ describe( 'Gutenberg Editor paste tests', () => {
await editorPage.removeBlockAtPosition( blockNames.paragraph, 1 );
} );

it( 'copies styled text from one paragraph block and pastes in another', async () => {
it.skip( 'copies styled text from one paragraph block and pastes in another', async () => {
// Create paragraph block with styled text by editing html.
await editorPage.setHtmlContent( testData.pasteHtmlText );
const paragraphBlockElement = await editorPage.getTextBlockAtPosition(
Expand Down