Skip to content

Experiment: Make block "synced" status applicable to all controlling blocks #46412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 6 commits into from
Closed

Experiment: Make block "synced" status applicable to all controlling blocks #46412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5ab813
Make sync status based on whether the block is controlling inner blocks
getdave Dec 8, 2022
2a800a2
Add sync status indicator to Block Card
getdave Dec 8, 2022
24cb51a
Correct comment
getdave Dec 8, 2022
03b0657
Apply ‘is-synced’ class to synced blocks and style consistently
getdave Dec 8, 2022
f843d89
Make status lozenge text size
getdave Dec 8, 2022
1deae8b
Avoid wrapping div on sync status lozenge
getdave Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid wrapping div on sync status lozenge
  • Loading branch information
@getdave
getdave committed Dec 8, 2022
commit 1deae8b4c700c00f9646a835b422a5e7f542c0e6
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/block-card/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ function BlockCard( { title, icon, description, blockType, className } ) {
<div className="block-editor-block-card__content">
<h2 className="block-editor-block-card__title">{ title }</h2>
{ isSynced && (
<div className="block-editor-block-card__sync-status">
<span>Synced</span>
</div>
<span className="block-editor-block-card__sync-status">
Synced
</span>
) }
<span className="block-editor-block-card__description">
{ description }
Expand Down
16 changes: 7 additions & 9 deletions packages/block-editor/src/components/block-card/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,13 @@
.block-editor-block-card__sync-status {
margin-block-start: $grid-unit-05;
margin-block-end: $grid-unit-15;

span {
display: inline-block;
color: #fff;
background-color: var(--wp-block-synced-color);
padding: 3px 6px;
font-size: 0.9em;
border-radius: $radius-block-ui;
}
display: block;
width: min-content;
color: #fff;
background-color: var(--wp-block-synced-color);
padding: 3px 6px;
font-size: 0.9em;
border-radius: $radius-block-ui;
}

.block-editor-block-card__description {
Expand Down